[llvm-branch-commits] [flang] [MLIR][OpenMP] Add Lowering support for OpenMP custom mappers in map clause (PR #121001)

[Akash Banerjee via llvm-branch-commits]

================
@@ -936,8 +936,10 @@ void ClauseProcessor::processMapObjects(
     llvm::omp::OpenMPOffloadMappingFlags mapTypeBits,
     std::map<Object, OmpMapParentAndMemberData> &parentMemberIndices,
     llvm::SmallVectorImpl<mlir::Value> &mapVars,
-    llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms) const {
+    llvm::SmallVectorImpl<const semantics::Symbol *> &mapSyms,
+    std::string mapperIdName) const {
----------------
TIFitis wrote:

In this case, even we accept a `StringRef`, we would have to immediately copy it to a `std:string` as we need to pass an `lvalue` to `converter.mangleName`. As such, wouldn't it be better to accept it as a string.

https://github.com/llvm/llvm-project/pull/121001