[llvm-branch-commits] [libc] fix: removes invalid token from LLVM_VERSION_SUFFIX in LIBC namespace (PR #126193)

Joseph Huber via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Fri Feb 7 05:42:26 PST 2025


================
@@ -51,7 +51,8 @@ set(LIBC_KERNEL_HEADERS "/usr/include" CACHE STRING "Path to Linux kernel header
 # Defining a global namespace to enclose all libc functions.
 set(default_namespace "__llvm_libc")
 if(LLVM_VERSION_MAJOR)
-  set(default_namespace "__llvm_libc_${LLVM_VERSION_MAJOR}_${LLVM_VERSION_MINOR}_${LLVM_VERSION_PATCH}_${LLVM_VERSION_SUFFIX}")
+  string(REPLACE "-" "" NS_LLVM_VERSION_SUFFIX ${LLVM_VERSION_SUFFIX})
----------------
jhuber6 wrote:

Do we even need the version suffix? If figured the patch is sufficient for that level of control.
```suggestion
  string(REPLACE "-" "_" NS_LLVM_VERSION_SUFFIX ${LLVM_VERSION_SUFFIX})
```

https://github.com/llvm/llvm-project/pull/126193


More information about the llvm-branch-commits mailing list