[llvm-branch-commits] [lldb] release/20.x: [lldb] Add support for gdb-style 'x' packet (#124733) (PR #125653)

[David Spickett via llvm-branch-commits]

DavidSpickett wrote:

I agree with backporting this.

There should be a release note for it. I know we could get away without it because the relevant GDB has not been out (maybe not at all) at this point, but it'll be something easy to point to for us in a few years time, and GDB folks who want to confirm what we did without reading our source code.

I suggest:
```
* Support was added for handling the GDB Remote Protocol `x` packet in the format introduced by GDB <version>. LLDB currently uses a different format for `x` and LLDB is now able to handle both formats. At some point in the future support for LLDB's format of `x` will be removed.
```

I think this can be done as a PR to the release branch? No need to complicate this one.

And it would be good to add a note to https://lldb.llvm.org/resources/lldbgdbremote.html#x-binary-memory-read (just on `main`) that says something like:
```
The format of this packet was decided before GDB <version> introduced its own format for x. Future versions of LLDB may not support the following format, and new code should produce and expect the format used by GDB.
```

https://github.com/llvm/llvm-project/pull/125653