[llvm-branch-commits] [llvm] Add option to emit call graph section (PR #87572)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Sat Feb 1 21:31:28 PST 2025


Prabhuk wrote:

> I think this is mostly fine, but the patch currently only adds the LLVM flag without doing anything. Perhaps this should be higher up in the stack(or I’m looking at them in the wrong order?)?
> 
> You may want to consider adding a test here to check that the option works. You could also precommit the tests you’re adding later in the stack, but since it’s a new feature I don’t think there’s much value in that.

Does merging this PR with #87574 (which is the next one to be landed after this one) effectively address your concerns here?

https://github.com/llvm/llvm-project/pull/87572


More information about the llvm-branch-commits mailing list