[llvm-branch-commits] [mlir] [mlir][draft] Consolidate patterns into `RegionBranchOpInterface` patterns (PR #174094)

[via llvm-branch-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>tools/mlir/lib/Dialect/SCF/IR/CMakeFiles/obj.MLIRSCFDialect.dir/SCF.cpp.o</summary>

```
FAILED: tools/mlir/lib/Dialect/SCF/IR/CMakeFiles/obj.MLIRSCFDialect.dir/SCF.cpp.o
sccache /opt/llvm/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/mlir/lib/Dialect/SCF/IR -I/home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/lib/Dialect/SCF/IR -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/mlir/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Werror=mismatched-tags -Werror=global-constructors -O3 -DNDEBUG -std=c++17 -UNDEBUG -fno-exceptions -funwind-tables -fno-rtti -MD -MT tools/mlir/lib/Dialect/SCF/IR/CMakeFiles/obj.MLIRSCFDialect.dir/SCF.cpp.o -MF tools/mlir/lib/Dialect/SCF/IR/CMakeFiles/obj.MLIRSCFDialect.dir/SCF.cpp.o.d -o tools/mlir/lib/Dialect/SCF/IR/CMakeFiles/obj.MLIRSCFDialect.dir/SCF.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/lib/Dialect/SCF/IR/SCF.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/lib/Dialect/SCF/IR/SCF.cpp:1296:44: error: captured structured bindings are a C++20 extension [-Werror,-Wc++20-extensions]
1296 |       rewriter.modifyOpInPlace(op, [&]() { op->eraseOperands(operands); });
|                                            ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/lib/Dialect/SCF/IR/SCF.cpp:1295:16: note: 'op' declared here
1295 |     for (auto [op, operands] : operandsToRemove) {
|                ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/lib/Dialect/SCF/IR/SCF.cpp:1296:62: error: captured structured bindings are a C++20 extension [-Werror,-Wc++20-extensions]
1296 |       rewriter.modifyOpInPlace(op, [&]() { op->eraseOperands(operands); });
|                                                              ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/lib/Dialect/SCF/IR/SCF.cpp:1295:20: note: 'operands' declared here
1295 |     for (auto [op, operands] : operandsToRemove) {
|                    ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/lib/Dialect/SCF/IR/SCF.cpp:1302:40: error: captured structured bindings are a C++20 extension [-Werror,-Wc++20-extensions]
1302 |                                [&]() { block->eraseArguments(blockArgs); });
|                                        ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/lib/Dialect/SCF/IR/SCF.cpp:1300:16: note: 'block' declared here
1300 |     for (auto [block, blockArgs] : blockArgsToRemove) {
|                ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/lib/Dialect/SCF/IR/SCF.cpp:1302:62: error: captured structured bindings are a C++20 extension [-Werror,-Wc++20-extensions]
1302 |                                [&]() { block->eraseArguments(blockArgs); });
|                                                              ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/mlir/lib/Dialect/SCF/IR/SCF.cpp:1300:23: note: 'blockArgs' declared here
1300 |     for (auto [block, blockArgs] : blockArgsToRemove) {
|                       ^
4 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/174094