[llvm-branch-commits] [mlir] [mlir][Transforms][NFC] `remove-dead-values`: Simplify dropped value handling (PR #173540)

[Matthias Springer via llvm-branch-commits]

matthias-springer wrote:

Yes that's right. They are already getting special handling before this PR. Note that they are not handled by `RDVFinalCleanupList::blocks`.

I found the `RDVFinalCleanupList::values` confusing because there are already two handlers for values: `RDVFinalCleanupList::blocks` (block argument) and `RDVFinalCleanupList::results` (op result). Correct me if I'm wrong, but the only reason why `RDVFinalCleanupList::values` exists is because `blocks` cannot be used. The function op want to handle argument erasure by itself (`funcOp.eraseArguments`).


https://github.com/llvm/llvm-project/pull/173540