[llvm-branch-commits] [clang] [Clang] Load pass plugins before parsing LLVM options (PR #171868)

[Alexis Engelke via llvm-branch-commits]

================
@@ -474,8 +475,11 @@ class CodeGenOptions : public CodeGenOptionsBase {
 
   std::vector<std::string> DefaultFunctionAttrs;
 
-  /// List of dynamic shared object files to be loaded as pass plugins.
-  std::vector<std::string> PassPlugins;
+  /// List of dynamic shared object file names to be loaded as pass plugins.
+  std::vector<std::string> PassPluginNames;
----------------
aengelke wrote:

Hmm, not sure: PassPluginNames is now processed much earlier than it was before, which would cause the more subtle breakage of plugins being silently ignored. (E.g., if a Clang front-end plugin contains `PassPlugins.push_back(somestring)`, with this patch right now it will fail to compile, but without renaming, the new name would be ignored because the plugin is never loaded -- CodeGen/BackendUtil doesn't do this anymore.)

https://github.com/llvm/llvm-project/pull/171868