[llvm-branch-commits] [lldb] Handle backwards branches in UnwindAssemblyInstEmulation (PR #169633)

[Jason Molenda via llvm-branch-commits]

================
@@ -530,19 +534,19 @@ bool UnwindAssemblyInstEmulation::WriteRegister(
   case EmulateInstruction::eContextAbsoluteBranchRegister:
   case EmulateInstruction::eContextRelativeBranchImmediate: {
     if (context.GetInfoType() == EmulateInstruction::eInfoTypeISAAndImmediate &&
-        context.info.ISAAndImmediate.unsigned_data32 > 0) {
+        context.info.ISAAndImmediate.unsigned_data32 != 0) {
       m_branch_offset = context.info.ISAAndImmediate.unsigned_data32;
----------------
jasonmolenda wrote:

FTR AArch64 can only branch +/- 128MB (unless it is doing a `b reg` or `bl reg`), well within a 32-bit signed byte offset.  But it's a good point, this is generic code and who knows what ISA we might be processing.

https://github.com/llvm/llvm-project/pull/169633