[llvm-branch-commits] [llvm] AMDGPU: Fix DPP combiner using isOperandLegal on incomplete inst (PR #155595)
Frederik Harwath via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Wed Aug 27 07:22:58 PDT 2025
================
@@ -431,6 +422,19 @@ MachineInstr *GCNDPPCombine::createDPPInst(MachineInstr &OrigMI,
DPPInst.add(*TII->getNamedOperand(MovMI, AMDGPU::OpName::row_mask));
DPPInst.add(*TII->getNamedOperand(MovMI, AMDGPU::OpName::bank_mask));
DPPInst.addImm(CombBCZ ? 1 : 0);
+
----------------
frederik-h wrote:
Perhaps add a comment explaining why it is necessary to perform this check here (as in the PR description: "It is not safe to use isOperandLegal on an instruction that does not have a complete set of operands. ...")?
https://github.com/llvm/llvm-project/pull/155595
More information about the llvm-branch-commits
mailing list