[llvm-branch-commits] [clang] release/21.x: [clang][PAC] Fix builtins that claim address discriminated types are bitwise compatible (#154490) (PR #155492)

[Nikita Popov via llvm-branch-commits]

================
@@ -634,7 +634,7 @@ class ASTContext : public RefCountedBase<ASTContext> {
   /// contain data that is address discriminated. This includes
   /// implicitly authenticated values like vtable pointers, as well as
   /// explicitly qualified fields.
-  bool containsAddressDiscriminatedPointerAuth(QualType T) {
+  bool containsAddressDiscriminatedPointerAuth(QualType T) const {
----------------
nikic wrote:

> @nikic this was targeting that release - I thought we had until the 28th?

You can find the release schedule in the sidebar on https://llvm.org/. The general rule is that LLVM always releases on Tuesdays.

> anyway, if that has shipped there's nothing we can do now except publish errata on broken behavior here

Why can't you just drop all the const qualifiers from this patch? That should be sufficient to avoid changing the symbol mangling.

https://github.com/llvm/llvm-project/pull/155492