[llvm-branch-commits] [llvm] [Github] Remove call to llvm-project-tests.yml from mlir-spirv-tests.yml (PR #153871)

[Aiden Grossman via llvm-branch-commits]

boomanaiden154 wrote:

> I wonder whether we gain enough to justify extra code duplication. Looking at llvm-project-tests.yml it doesn't seem to do that much additional work and it's quite simple.

1. There is all the plumbing to actually make the call work.
2. It contains support for multiple platforms when all in-tree callers only use Linux.
3. It contains explicit support for things like libclc which no one uses in-tree.

This will also be the last user of the workflow after https://github.com/llvm/llvm-project/pull/153876 lands.

I don't see how this adds extra maintenance burden on anyone working on MLIR SPIRV. It makes hacking on the workflow simpler because instead of having to dig through Github plumbing, the workflow is now a CMake+ninja invocation that every LLVM developer will understand along with a fully standard cache/checkout action.

If there are any changes common to all the workflows, I'm usually the one making them, and the difficulty of making such changes will stay the same with this patch.

https://github.com/llvm/llvm-project/pull/153871