[llvm-branch-commits] [llvm] [AMDGPU][UnifyDivergentExitNodes][StructurizeCFG] Add support for callbr instruction with inline-asm (PR #152161)
Robert Imschweiler via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Wed Aug 6 06:23:49 PDT 2025
ro-i wrote:
> 1. Can we remove the pass names added as tags? They don't actually add any new information to the commit headline.
I think they do. I developed and submitted the PR to support inline-asm for amdgpu as two PRs so that it's not too large and easier to review. So, if I would call https://github.com/llvm/llvm-project/pull/149308 "[AMDGPU] Support callbr with inline-asm" instead of "[AMDGPU][FixIrreducible][UnifyLoopExits] Support callbr with inline-asm" this would be a lie since this PR here is needed, too.
> 2. What does "basic" support signify? What is pending before we can call it "complete" support?
Thanks, I removed the "basic" since it's misleading. For me, "basic" = "inline-asm" and "complete" = "inline-asm + intrinsics", but that is in no way based on any commonly used definition.
https://github.com/llvm/llvm-project/pull/152161
More information about the llvm-branch-commits
mailing list