[llvm-branch-commits] [llvm] [AArch64][llvm] Pre-commit tests for #137703 (NFC) (PR #137702)

Jonathan Thackray via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Apr 29 05:16:45 PDT 2025


jthackray wrote:

> Should I look at the ABI to understand if these tests are lowering properly? Like in here: https://github.com/ARM-software/abi-aa/blob/main/atomicsabi64/atomicsabi64.rst#id30

Yes, https://github.com/ARM-software/abi-aa/blob/main/atomicsabi64/atomicsabi64.rst#bit-floating-point-types shows what the instructions should be before and after.

In PR #137703, you can see in the diffs that this changes to a single `ldfmax` instruction (note, not `ldfmaxnm`, as these were added in #125686).

- `atomicrmw fmax` lowers to `ldfmaxnm` instruction
- `atomicrmw fmaximum` lowers to `ldfmax` instruction
and obviously the fmin/fminimum are similar.

https://github.com/llvm/llvm-project/pull/137702


More information about the llvm-branch-commits mailing list