[llvm-branch-commits] [llvm] [KeyInstr][DwarfDebug] Add is_stmt emission support (PR #133495)

[Jeremy Morse via llvm-branch-commits]

https://github.com/jmorse commented:

Tests: I'd personally prefer the input source and explanation at the top of the file, although this is a style thing.

My understanding of this code is that within a basic block, it should be possible for there to be two sequences of instructions of equal group and rank that both get a buoy and is_stmt, if they're separated by some other atom group. Perhaps I'm wrong; but if I'm right, it probably wants explicit test coverage.

There's a risk that the code being generated is brittle and frequently needs updating; I don't know what probability of that we find acceptable, let's just see how often it needs updating I guess.

https://github.com/llvm/llvm-project/pull/133495