[llvm-branch-commits] [lldb] [lldb][nfc] Remove unused parameters in ThreadPlanStepOut ctor (PR #136161)
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Thu Apr 17 11:27:50 PDT 2025
https://github.com/jimingham commented:
Removing the symbol context is fine. I'm not even sure it's necessary - the code that queues up the plan should really be the on to calculate where this should go to, and the plan can then just trust the frame_index it got passed.
The first_insn was there to help the unwinder in the case where you stepped into code with no debug information and the code you stepped to was stripped so we didn't have function bounds. The "step-in" plan could know that it just stepped through an instruction that pushes a frame, so even without function bounds it's a pretty good guess this is the first instruction of a function. That still seems like a useful piece of information.
https://github.com/llvm/llvm-project/pull/136161
More information about the llvm-branch-commits
mailing list