[llvm-branch-commits] [llvm] [BOLT][test] Fix callcont-fallthru.s after #129481 (PR #135867)

[Fangrui Song via llvm-branch-commits]

MaskRay wrote:

> Hey Amir,
> 
> Thanks for the PR. Unfortunately, it is still failing. The trick below doesn't seem to work on my buildbot machine:
> 
> > Link against a DSO to ensure PLT entries.
> 
> So doing:
> 
> ```shell
> nm --synthetic callcont-fallthru.s.tmp
> ```
> 
> won't list a `puts at plt` symbol, which is what causes an `link_fdata.py` assertion:
> 
> > AssertionError: ERROR: symbol puts at plt is not defined in binary
> 
> On my dev AArch64 instance `--synthetic` does the trick. BTW run lines 4 and 6 appear identical when inspected (`-###`)

You need a `libc.so` that defines `puts`, and then creates an executable that references `puts` and links against `libc.so`. Then the executable will have a PLT entry, and you do not need the `--unresolved-symbols=ignore-all` hack.

https://github.com/llvm/llvm-project/pull/135867