[llvm-branch-commits] [mlir] [MLIR][ArmSVE] Add an ArmSVE dialect operation which maps to svusmmla (PR #135634)

Andrzej WarzyƄski via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon Apr 14 13:24:11 PDT 2025


================
@@ -273,6 +273,34 @@ def UmmlaOp : ArmSVE_Op<"ummla",
     "$acc `,` $src1 `,` $src2 attr-dict `:` type($src1) `to` type($dst)";
 }
 
+def UsmmlaOp : ArmSVE_Op<"usmmla", [Pure,
+                                    AllTypesMatch<["src1", "src2"]>,
+                                    AllTypesMatch<["acc", "dst"]>]> {
----------------
banach-space wrote:

This indentation is inconsistent with the other ops, but the existing indentation feels a bit ad-hoc. I like yours much more.

Would you mind updating other definitions so that we do maintain consistency? Probably as a separate PR to keep the history clean. Updating this PR instead would also be fine with me.

https://github.com/llvm/llvm-project/pull/135634


More information about the llvm-branch-commits mailing list