[llvm-branch-commits] [llvm] [AMDGPU][InsertWaitCnts] Track global_wb/inv/wbinv (PR #135340)
Pierre van Houtryve via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Mon Apr 14 00:49:12 PDT 2025
================
@@ -698,6 +698,16 @@ class SIInsertWaitcnts {
// Return the appropriate VMEM_*_ACCESS type for Inst, which must be a VMEM or
// FLAT instruction.
WaitEventType getVmemWaitEventType(const MachineInstr &Inst) const {
+ switch (Inst.getOpcode()) {
----------------
Pierre-vh wrote:
After looking more into this, the fix is correct and needed for correctness, at least the WB part.
I'm on the fence about the INV portion. We could get away without tracking it, but I feel like not tracking an operation is risking bugs in the future
I could track it but not add it to the set of pending operations.
https://github.com/llvm/llvm-project/pull/135340
More information about the llvm-branch-commits
mailing list