[llvm-branch-commits] [llvm] [KeyInstr] Merge atoms in DILocation::getMergedLocation (PR #133480)

Jeremy Morse via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Fri Apr 11 01:49:31 PDT 2025


https://github.com/jmorse commented:

Looks good, although I think the atom-group selection could be refactored so that it's simpler to read. There's already multiple levels of nesting happening in that function, best to reduce that as much as possible (possibly put it in a completely different helper function to separate the concerns?)

https://github.com/llvm/llvm-project/pull/133480


More information about the llvm-branch-commits mailing list