[llvm-branch-commits] [llvm] [KeyInstr] Add Atom Group waterline to LLVMContext (PR #133478)

[Jeremy Morse via llvm-branch-commits]

https://github.com/jmorse commented:

Are there any expected interactions between atom-group-numbers and loading bitcode? i.e., if we serialise the literal atom-group-number to the output and then read it back in again, then it might conflict with atom-group-numbers seen in other functions in other bitcode files. It doesn't appear that they get re-numbered in the textual IR parsing patch for example.

Possibly part of the design here is to simply not care, if it's only about internal consistency within a Function (does that hold after inlining too). Apologies if this is all explained in a later patch.

The answers to that should ultimately be documented somewhere; I imagine that's in the patch stack or coming later.

https://github.com/llvm/llvm-project/pull/133478