[llvm-branch-commits] [llvm] Add initial support for SPE brstack format (PR #129231)
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Thu Apr 10 06:28:13 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 47a986de762147c4f27a20ff9b1d75f9f5a50bdc aec7a556fed56c72184963d21d6893e586d6a7e2 --extensions cpp -- bolt/lib/Profile/DataAggregator.cpp bolt/unittests/Profile/PerfSpeEvents.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/bolt/lib/Profile/DataAggregator.cpp b/bolt/lib/Profile/DataAggregator.cpp
index 4273eda865..bcb3b2c8ef 100644
--- a/bolt/lib/Profile/DataAggregator.cpp
+++ b/bolt/lib/Profile/DataAggregator.cpp
@@ -1035,19 +1035,20 @@ ErrorOr<LBREntry> DataAggregator::parseLBREntry() {
return EC;
StringRef MispredStr = MispredStrRes.get();
// SPE brstack mispredicted flags might be two characters long: 'PN' or 'MN'.
- bool ValidStrSize = opts::ArmSPE ?
- MispredStr.size() >= 1 && MispredStr.size() <= 2 : MispredStr.size() == 1;
+ bool ValidStrSize = opts::ArmSPE
+ ? MispredStr.size() >= 1 && MispredStr.size() <= 2
+ : MispredStr.size() == 1;
bool SpeTakenBitErr =
- (opts::ArmSPE && MispredStr.size() == 2 && MispredStr[1] != 'N');
+ (opts::ArmSPE && MispredStr.size() == 2 && MispredStr[1] != 'N');
bool PredictionBitErr =
- !ValidStrSize ||
- (MispredStr[0] != 'P' && MispredStr[0] != 'M' && MispredStr[0] != '-');
+ !ValidStrSize ||
+ (MispredStr[0] != 'P' && MispredStr[0] != 'M' && MispredStr[0] != '-');
if (SpeTakenBitErr)
reportError("expected 'N' as SPE prediction bit for a not-taken branch");
if (PredictionBitErr)
reportError("expected 'P', 'M' or '-' char as a prediction bit");
- if (SpeTakenBitErr || PredictionBitErr) {
+ if (SpeTakenBitErr || PredictionBitErr) {
Diag << "Found: " << MispredStr << "\n";
return make_error_code(llvm::errc::io_error);
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/129231
More information about the llvm-branch-commits
mailing list