[llvm-branch-commits] Add pointer field protection feature. (PR #133538)

[Mark de Wever via llvm-branch-commits]

mordante wrote:

> > in libc++ we have a pre-commit CI so this feature should be tested in our CI, if you need help with that, best reach out to us on Discord. However I think we first need to look at how we can properly integrate this in libc++.
> 
> Sure, I will get in touch once this is closer to landing (everything else in [Structure Protection](https://github.com/orgs/llvm/projects/38) needs to land first). So far I've been running the libc++ test suite manually with some hand written cfg files but it would be good to get everything hooked up so that the tests can run in CI as well.

SGTM!

Looking at your replies I think we indeed need to add a new configuration for this feature, much like building without RTTI or exceptions.

> > I'm not fond of this patch since it mixes LLVM, Clang, and libc++(abi) code. This makes it hard to determine when all reviewer groups are satisfied. Is there a reason why the libc++ and the libc++abi part can't be in two separate patches?
> 
> No problem, I'll split up the libc++ and libc++abi parts into separate patches the next time I upload.

Thanks!

https://github.com/llvm/llvm-project/pull/133538