[llvm-branch-commits] Add pointer field protection feature. (PR #133538)

[Mark de Wever via llvm-branch-commits]

https://github.com/mordante requested changes to this pull request.

Some comments from libc++'s perspective:
- As you mentioned you need more tests.
- I think the current approach with a header only libc++ change approach will not work due to ABI changes. See review comment for `std::vector`.
- in libc++ we have a pre-commit CI so this feature should be tested in our CI, if you need help with that, best reach out to us on Discord. However I think we first need to look at how we can properly integrate this in libc++.

I'm not fond of this patch since it mixes LLVM, Clang, and libc++(abi) code. This makes it hard to determine when all reviewer groups are satisfied. Is there a reason why the libc++ and the libc++abi part can't be in two separate patches? 

(I don't know whether it makes sense to keep the LLVM & Clang part in one patch.)







https://github.com/llvm/llvm-project/pull/133538