[llvm-branch-commits] [mlir] [MLIR][OpenMP] Document entry block argument-defining clauses (NFC) (PR #109811)
Pranav Bhandarkar via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Mon Sep 30 13:54:21 PDT 2024
================
@@ -285,7 +285,75 @@ argument's type:
specific `mlir::Attribute` subclass) will be used instead.
- Other attribute types will be represented with their `storageType`.
- It will create `<Name>Operands` structure for each operation, which is an
-empty structure subclassing all operand structures defined for the corresponding `OpenMP_Op`'s clauses.
+empty structure subclassing all operand structures defined for the corresponding
+`OpenMP_Op`'s clauses.
+
+### Entry Block Argument-Defining Clauses
+
+Certain OpenMP clauses introduce in their MLIR representation mappings between
----------------
bhandarkar-pranav wrote:
<Subjective review comment>Could you consider the following reordering and slight rewording of the first sentence?
```
In their MLIR representation, certain OpenMP clauses introduce a mapping between values defined outside the operation they are applied to and entry block arguments for the region of that MLIR operation.
```
https://github.com/llvm/llvm-project/pull/109811
More information about the llvm-branch-commits
mailing list