[llvm-branch-commits] [llvm] [AArch64] Consistently use EmitToStreamer across the AArch64AsmPrinter (PR #110107)
Anatoly Trosinenko via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Thu Sep 26 10:16:24 PDT 2024
atrosinenko wrote:
Thank you for the review!
> As you are adding a new function, it's good time to fix the naming case to `emitToStreamer`
I think renaming `EmitToStreamer` to `emitToStreamer` now may be a bit error-prone, as this function overrides the non-virtual `AsmPrinter::EmitToStreamer`, so in `AArch64AsmParser` there would be two different functions accessible with almost identical names and almost identical implementations.
https://github.com/llvm/llvm-project/pull/110107
More information about the llvm-branch-commits
mailing list