[llvm-branch-commits] [llvm] [ADT] Use range-based helper functions in SmallSet (PR #108585)

[Nikita Popov via llvm-branch-commits]

================
@@ -234,19 +225,12 @@ class SmallSet {
   /// Check if the SmallSet contains the given element.
   bool contains(const T &V) const {
     if (isSmall())
-      return vfind(V) != Vector.end();
-    return Set.find(V) != Set.end();
+      return llvm::is_contained(Vector, V);
+    return llvm::is_contained(Set, V);
----------------
nikic wrote:

It doesn't matter what it actually calls, we should never use is_contained() for set structures, unless there is some very, very strong reason (e.g. generic context that really does not core whether it gets an O(1) set or O(n) set).

https://github.com/llvm/llvm-project/pull/108585