[llvm-branch-commits] [llvm] [ADT] Use range-based helper functions in SmallSet (PR #108585)

Victor Campos via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Sep 17 04:52:13 PDT 2024


================
@@ -234,19 +225,12 @@ class SmallSet {
   /// Check if the SmallSet contains the given element.
   bool contains(const T &V) const {
     if (isSmall())
-      return vfind(V) != Vector.end();
-    return Set.find(V) != Set.end();
+      return llvm::is_contained(Vector, V);
+    return llvm::is_contained(Set, V);
----------------
vhscampos wrote:

Thanks for pointing that out. I've checked and `llvm::is_contained` indeed does a linear scan on a `std::set` because the latter does not have a `contains` method before C++20.

https://github.com/llvm/llvm-project/pull/108585


More information about the llvm-branch-commits mailing list