[llvm-branch-commits] [llvm] release/19.x: [RISCV] Don't outline pcrel_lo when the function has a section prefix (#107943) (PR #108288)

Pengcheng Wang via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Thu Sep 12 23:32:44 PDT 2024


wangpc-pp wrote:

> Hi, since we are wrapping up LLVM 19.1.0 we are very strict with the fixes we pick at this point. Can you please respond to the following questions to help me understand if this has to be included in the final release or not.
> 
> Is this PR a fix for a regression or a critical issue?

This PR is a fix for https://github.com/llvm/llvm-project/issues/107520, which is a correctness issue about MachineOutliner for RISC-V target.

> 
> What is the risk of accepting this into the release branch?

No risk I think. It fixes a correctnesss issue.

> 
> What is the risk of NOT accepting this into the release branch?

If not, for some cases, we will generate wrong outling results for RISC-V target.

https://github.com/llvm/llvm-project/pull/108288


More information about the llvm-branch-commits mailing list