[llvm-branch-commits] [clang] Backport "[clang][analyzer] Fix #embed crash (#107764)" (PR #107841)

[Donát Nagy via llvm-branch-commits]

NagyDonat wrote:

> Is this PR a fix for a regression or a critical issue?

`#embed` support is a new feature introduced in Clang 19, so this is not a regression. However, without this PR Clang Static Analyzer (and clang-tidy which calls Clang Static Analyzer) will crash on any project that contains an `#embed` directive.

> What is the risk of accepting this into the release branch?

Instead of crashing outright, the static analysis will continue after the `#embed` directive. This could theoretically lead to incorrect analyzer behavior (other crashes, bad analysis results etc.), but there is no reason to expect any issues.

> What is the risk of NOT accepting this into the release branch?

Clang Static Analyzer and clang-tidy will crash on code that contain `#embed` directives. 

https://github.com/llvm/llvm-project/pull/107841