[llvm-branch-commits] [compiler-rt] [profile] Change __llvm_profile_counter_bias type to match llvm (PR #107362)

Rainer Orth via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Sep 10 00:16:22 PDT 2024


rorth wrote:

> Hi, since we are wrapping up LLVM 19.1.0 we are very strict with the fixes we pick at this point. Can you please respond to the following questions to help me understand if this has to be included in the final release or not.

I guess it's best for @petrhosek to make the final assessment.  That said...

> Is this PR a fix for a regression or a critical issue?

... it's not a regression but a long(er)-standing bug.  Critical?  Probably not.

> What is the risk of accepting this into the release branch?
> 
> What is the risk of NOT accepting this into the release branch?

Although this has been on `main` for a couple of days now without complaint, I'd say it's safer to delay to a later 19.x.0 release at this point.

https://github.com/llvm/llvm-project/pull/107362


More information about the llvm-branch-commits mailing list