[llvm-branch-commits] [llvm] release/19.x: [LoongArch][ISel] Check the number of sign bits in `PatGprGpr_32` (#107432) (PR #107945)

Yingwei Zheng via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Sep 10 00:15:34 PDT 2024


dtcxzyw wrote:

> Hi, since we are wrapping up LLVM 19.1.0 we are very strict with the fixes we pick at this point. Can you please respond to the following questions to help me understand if this has to be included in the final release or not.
> 
> Is this PR a fix for a regression or a critical issue?

Yes. It fixes a miscompilation reported in https://github.com/llvm/llvm-project/pull/107432.

> What is the risk of accepting this into the release branch?

It introduces a performance regression. I have filed an issue to track this: https://github.com/llvm/llvm-project/issues/107946.

> What is the risk of NOT accepting this into the release branch?

ISel for 32-bit signed div/rem stays broken on LoongArch64.


https://github.com/llvm/llvm-project/pull/107945


More information about the llvm-branch-commits mailing list