[llvm-branch-commits] [DirectX] Lower `@llvm.dx.typedBufferStore` to DXIL ops (PR #104253)

[Farzon Lotfi via llvm-branch-commits]

================
@@ -94,6 +95,7 @@ class OpLowerer {
         DiagnosticInfoUnsupported Diag(*CI->getFunction(), Message,
                                        CI->getDebugLoc());
         M.getContext().diagnose(Diag);
+        HasErrors = true;
----------------
farzonl wrote:

`HasErrors ` updated in `replaceFunction` but being used in `lowerIntrinsics` seems like it forces synchronization.  That should be fine because we don't do parallel code gen. 

That said would it complicate things to much to propagate up the error from `replaceFunction` to `lowerTypedBufferStore` to `lowerIntrinsics`? That way we don't have behavior dependent on side effects.

https://github.com/llvm/llvm-project/pull/104253