[llvm-branch-commits] [DirectX] Lower `@llvm.dx.typedBufferLoad` to DXIL ops (PR #104252)

Justin Bogner via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon Sep 9 12:13:03 PDT 2024


================
@@ -450,6 +462,10 @@ CallInst *DXILOpBuilder::createOp(dxil::OpCode OpCode, ArrayRef<Value *> Args,
   return *Result;
 }
 
+StructType *DXILOpBuilder::getResRetType(Type *ElementTy) {
+  return ::getResRetType(ElementTy);
----------------
bogner wrote:

This pattern isn't great, and I expect it to go away eventually. The `getResRetType` static function already exists and is called by other static functions, so simply making it a member involves quite a bit of code churn. Further, most of the uses in static functions are in code that has various TODOs about refactoring how we use TableGen in order to simplify it, so I'd rather not spend a lot of time on it until we actually do that.

https://github.com/llvm/llvm-project/pull/104252


More information about the llvm-branch-commits mailing list