[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

[Ilya Biryukov via llvm-branch-commits]

ilya-biryukov wrote:

We did manage to run another round of testing and it fails, with somewhat familiar module-related issues:

```cpp
[third_party/absl/container/internal/compressed_tuple.h:250]:24: error: 'absl::container_internal::CompressedTuple<absl::container_internal::CommonFields, absl::container_internal::StringHash, absl::container_internal::StringEq, std::allocator<std::pair<const std::string, std::string>>>::get' from module '//third_party/absl/container:compressed_tuple.third_party/absl/container/internal/compressed_tuple.h' is not present in definition of 'absl::container_internal::CompressedTuple<absl::container_internal::CommonFields, absl::container_internal::StringHash, absl::container_internal::StringEq, std::allocator<std::pair<const std::string, std::string>>>' provided earlier
  250 |   constexpr ElemT<I>&& get() && {
```

I am progressing towards a reproducer, hope to share something early next week.

https://github.com/llvm/llvm-project/pull/83237