[llvm-branch-commits] [llvm] [RISCV][NFC] refactor CFI emitting (PR #114227)

Sam Elliott via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Oct 30 12:19:56 PDT 2024


================
@@ -1737,39 +1776,14 @@ void RISCVFrameLowering::emitCalleeSavedRVVPrologCFI(
   for (auto &CS : RVVCSI) {
     // Insert the spill to the stack frame.
     int FI = CS.getFrameIdx();
----------------
lenary wrote:

Is there a reason you didn't replace this loop with a call to `emitCFIforCSI` with a new `CFISaveRVVRegisterEmitter`? That would give a little better symmetry in those objects, even though it doesn't get rid of the calls to `emitCalleeSavedRVVPrologCFI` because of the other logic happening before this loop.

https://github.com/llvm/llvm-project/pull/114227


More information about the llvm-branch-commits mailing list