[llvm-branch-commits] [mlir] [OpenMP][MLIR] Descriptor explicit member map lowering changes (PR #113556)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Oct 30 08:29:47 PDT 2024


agozillon wrote:

> LGTM, but buildbot errors in "MapInfoFinalization.cpp", "MapsForPrivatizedSymbols.cpp" and "Utils.cpp" seem to be a consequence of the type change to `members_index`. Hopefully it's a simple fix.

I have a feeling it's just not setup correctly to layer on top of it's dependent PRs, hence the errors. As in conjunction it all builds fine and runs on my machine and I'll double check again before landing the PR stack :-)

Would love an approval if you're happy with the PRs current state!

And would love an approval or further review comments from @ergawy @TIFitis if at all possible, would be wonderful to be able to land this in the next week or two as it seems to be approaching closure :-) 

https://github.com/llvm/llvm-project/pull/113556


More information about the llvm-branch-commits mailing list