[llvm-branch-commits] [mlir] [MLIR][OpenMP] Emit descriptive errors for all unsupported clauses (PR #114037)

Sergio Afonso via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Oct 29 10:09:02 PDT 2024


================
@@ -640,6 +642,13 @@ convertOmpOrdered(Operation &opInst, llvm::IRBuilderBase &builder,
   return success();
 }
 
+static LogicalResult orderedRegionSupported(omp::OrderedRegionOp op) {
----------------
skatrak wrote:

Thanks for the comment @Meinersbur. I was actually planning on creating a follow-up PR to centralize this a bit more, but I decided that it might help address your comments so I made these changes here. Yes, the idea is to have this be called for all operations regardless of how many unimplemented clauses they have, for consistency. Hopefully the template approach I updated this PR with works for you.

https://github.com/llvm/llvm-project/pull/114037


More information about the llvm-branch-commits mailing list