[llvm-branch-commits] [mlir] [MLIR][OpenMP] Emit descriptive errors for all unsupported clauses (PR #114037)

[Michael Kruse via llvm-branch-commits]

================
@@ -640,6 +642,13 @@ convertOmpOrdered(Operation &opInst, llvm::IRBuilderBase &builder,
   return success();
 }
 
+static LogicalResult orderedRegionSupported(omp::OrderedRegionOp op) {
----------------
Meinersbur wrote:

[function names should start with a verb](https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly): `checkWhetherOrderedRegionSupported` or maybe `checkImplementationStatus`.

A Doxygen brief could explain the purpose of this function (not exactly what it is checking, I can see that in the code).

This applies to the helper functions below as well. I don't see the point of extracting out a single check, but seems useful if there are multiple checks and apply the same pattern here as well.

https://github.com/llvm/llvm-project/pull/114037