[llvm-branch-commits] [llvm] release/19.x: [loongarch][DAG][FREEZE] Fix crash when FREEZE a half(f16) type on loongarch (#107791) (PR #109093)
Trevor Gross via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Mon Oct 28 01:47:22 PDT 2024
tgross35 wrote:
> @heiher this would still break the ABI right? so it would still create problem for downstream users like rust?
Speaking only from a Rust perspective, don't worry too much about making breaking changes that fix `f16` or `f128` behavior. The types are nightly-only for now (probably will be that way for at least a year or so) so we don't have any public guarantees. (I would just get to un-skip `f16` tests on another arch sooner).
I don't know what other frontends exposes this type but the commit mentions Zig.
If it is preferable to keep using float registers, it sounds like there is another fix for the precision issue rather than changing the ABI https://github.com/llvm/llvm-project/issues/97975#issuecomment-2218678418. I don't think there is a test for the precision yet.
https://github.com/llvm/llvm-project/pull/109093
More information about the llvm-branch-commits
mailing list