[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

Vassil Vassilev via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Oct 23 23:17:33 PDT 2024


vgvassilev wrote:

> @alexfh thank you very much!
> 
> @vgvassilev but we have to provide similar mechanism, so it is allowed to get all the specializations for a templated decl.

I think this is the code snippet we are bitten by:

https://github.com/llvm/llvm-project/blob/d1fae5996e66c2a9f0b1c5b9776f86962ab8e9ea/clang/lib/Sema/SemaTemplate.cpp#L4382-L4402

I have several random thoughts:
* Iterations of these kinds are expensive for modules -- can we do something about that code, perhaps @zygoloid could give us a hint.
* @ChuanqiXu9, do we store all template variable specializations in the same place in the map including the partial ones?

https://github.com/llvm/llvm-project/pull/83237


More information about the llvm-branch-commits mailing list