[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

[Alexander Kornienko via llvm-branch-commits]

alexfh wrote:

BTW, if you wonder about the callers of `LoadExternalSpecializations`:
```
-   90.30%     0.00%  clang  clang               [.] clang::Sema::CheckVarTemplateId(clang::VarTemplateDecl*, clang::SourceLocation, clang::SourceLocation, clang::TemplateArgumentListInfo const&)                  ▒
   - 90.30% clang::Sema::CheckVarTemplateId(clang::VarTemplateDecl*, clang::SourceLocation, clang::SourceLocation, clang::TemplateArgumentListInfo const&)                                                           ▒
      - 89.47% clang::VarTemplateDecl::getPartialSpecializations(llvm::SmallVectorImpl<clang::VarTemplatePartialSpecializationDecl*>&) const                                                                         ▒
         - 89.46% clang::ASTReader::LoadExternalSpecializations(clang::Decl const*, bool)                                                                                                                            ▒
            - 88.08% clang::serialization::MultiOnDiskHashTable<clang::serialization::reader::LazySpecializationInfoLookupTrait>::findAll()                                                                          ▒
               - 20.24% llvm::DenseMap<clang::serialization::reader::LazySpecializationInfo, llvm::detail::DenseSetEmpty, llvm::DenseMapInfo<clang::serialization::reader::LazySpecializationInfo, void>, llvm::detai▒
                  + 0.82% 0xffffffff8b4012a6                                                                                                                                                                         ▒
               - 7.22% llvm::SmallVectorBase<unsigned int>::grow_pod(void*, unsigned long, unsigned long)                                                                                                            ▒
                  - 7.11% memcpy_prefetch                                                                                                                                                                            ▒
                     + 1.52% 0xffffffff8b4012a6                                                                                                                                                                      ▒
```

https://github.com/llvm/llvm-project/pull/83237