[llvm-branch-commits] [llvm] [StructuralHash] Support Differences (PR #112638)

[Aiden Grossman via llvm-branch-commits]

boomanaiden154 wrote:

> IIRC we have several lit tests that cover structural hash, shouldn't we have a new test there that uses the new functionality?

The lit tests for structural hashing are pretty limited and mostly designed to just test the structural hash printer pass that I needed for other things rather than just testing within LLVM. Adding new lit tests definitely wouldn't hurt, but typically unit testing makes a lot more sense for what StructuralHash is supposed to guarantee.

> The test failure TableGen/x86-fold-tables.td seems unrelated.

Yes. https://github.com/llvm/llvm-project/issues/112961 seems to have more information.

https://github.com/llvm/llvm-project/pull/112638