[llvm-branch-commits] [llvm] GlobalISel: Fix combine duplicating atomic loads (PR #111730)

Matt Arsenault via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Oct 9 12:26:52 PDT 2024


arsenm wrote:

> The duplicating is only due to atomicity of the load?

The duplicating is the apparent effect because the non-atomic load can be deleted. There's no plus to keeping it around 

> if (atomic)
>   EraseFromParent();
> ```

This just adds extra work for later code to delete. The zextload equivalent combine already directly deletes the load 



https://github.com/llvm/llvm-project/pull/111730


More information about the llvm-branch-commits mailing list