[llvm-branch-commits] [llvm] [MIR] Add missing noteNewVirtualRegister callbacks (PR #111634)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Oct 9 02:18:49 PDT 2024


Ayush9054 wrote:

Observation:

It has come to our attention that the changes made in llvm/lib/CodeGen/MIRParser/MIRParser.cpp are not related to the current pull request (PR). As these modifications do not pertain directly to the functionality addressed in this PR, they should be extracted and submitted as a separate non-functional change (NFC) patch.

Action Plan:

Create a Separate NFC Patch:

Isolate the changes made in MIRParser.cpp.
Ensure that the patch focuses solely on the improvements or refactoring present in that file without impacting the main objectives of the current PR.
Submit the Patch:

Once isolated, submit the NFC patch for review.
Ensure that the description clearly outlines the purpose of the changes made in MIRParser.cpp.
Next Steps:

Please prioritize the creation and submission of the NFC patch to maintain clarity and organization within the codebase.
Thank you for your attention to this mat

https://github.com/llvm/llvm-project/pull/111634


More information about the llvm-branch-commits mailing list