[llvm-branch-commits] [llvm] release/19.x: [LICM] allow MemoryAccess creation failure (#116813) (PR #117082)

[Nikita Popov via llvm-branch-commits]

================
@@ -192,6 +192,12 @@ class MemorySSAUpdater {
                                        const BasicBlock *BB,
                                        MemorySSA::InsertionPlace Point);
 
+  MemoryAccess *createMemoryAccessInBB2(Instruction *I,
+                                        MemoryAccess *Definition,
+                                        const BasicBlock *BB,
+                                        MemorySSA::InsertionPlace Point,
+                                        bool CreationMustSucceed = true);
----------------
nikic wrote:

```suggestion
  MemoryAccess *createMemoryAccessInBB(Instruction *I,
                                       MemoryAccess *Definition,
                                       const BasicBlock *BB,
                                       MemorySSA::InsertionPlace Point,
                                       bool CreationMustSucceed);
```
This can be an overload with the extra parameter, no need to use a different name.

https://github.com/llvm/llvm-project/pull/117082