[llvm-branch-commits] [clang] e7efa82 - Revert "[TargetVersion] Only enable on RISC-V and AArch64 (#115991)"

[via llvm-branch-commits]

Author: Piyou Chen
Date: 2024-11-21T12:47:23+08:00
New Revision: e7efa82cb1362e8a2eae63fa66954327de50b88a

URL: https://github.com/llvm/llvm-project/commit/e7efa82cb1362e8a2eae63fa66954327de50b88a
DIFF: https://github.com/llvm/llvm-project/commit/e7efa82cb1362e8a2eae63fa66954327de50b88a.diff

LOG: Revert "[TargetVersion] Only enable on RISC-V and AArch64 (#115991)"

This reverts commit 922282eacfc054ddadbec04825d6573179e66200.

Added: 
    

Modified: 
    clang/docs/ReleaseNotes.rst
    clang/include/clang/Basic/Attr.td

Removed: 
    clang/test/Sema/attr-target-version-unsupported.c


################################################################################
diff  --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index a2ff05438c949a..999c88455b64a5 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -459,8 +459,6 @@ Attribute Changes in Clang
 - Clang now supports ``[[clang::lifetime_capture_by(X)]]``. Similar to lifetimebound, this can be
   used to specify when a reference to a function parameter is captured by another capturing entity ``X``.
 
-- The ``target_version`` attribute is now only supported for AArch64 and RISC-V architectures.
-
 Improvements to Clang's diagnostics
 -----------------------------------
 

diff  --git a/clang/include/clang/Basic/Attr.td b/clang/include/clang/Basic/Attr.td
index f1780fa1067352..634253d0032560 100644
--- a/clang/include/clang/Basic/Attr.td
+++ b/clang/include/clang/Basic/Attr.td
@@ -3297,7 +3297,7 @@ def Target : InheritableAttr {
   }];
 }
 
-def TargetVersion : DeclOrTypeAttr, TargetSpecificAttr<TargetArch<!listconcat(TargetAArch64.Arches, TargetRISCV.Arches)>> {
+def TargetVersion : InheritableAttr {
   let Spellings = [GCC<"target_version">];
   let Args = [StringArgument<"NamesStr">];
   let Subjects = SubjectList<[Function], ErrorDiag>;

diff  --git a/clang/test/Sema/attr-target-version-unsupported.c b/clang/test/Sema/attr-target-version-unsupported.c
deleted file mode 100644
index 7cf8172f5272e6..00000000000000
--- a/clang/test/Sema/attr-target-version-unsupported.c
+++ /dev/null
@@ -1,4 +0,0 @@
-// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -verify %s
-
-//expected-warning at +1 {{unknown attribute 'target_version' ignored}}
-int __attribute__((target_version("aes"))) foo(void) { return 3; }