[llvm-branch-commits] [mlir] [MLIR][OpenMP] Add host_eval clause to omp.target (PR #116049)

Anchu Rajendran S via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon Nov 18 13:55:46 PST 2024


================
@@ -1166,9 +1166,10 @@ def TargetOp : OpenMP_Op<"target", traits = [
   ], clauses = [
     // TODO: Complete clause list (defaultmap, uses_allocators).
     OpenMP_AllocateClause, OpenMP_DependClause, OpenMP_DeviceClause,
-    OpenMP_HasDeviceAddrClause, OpenMP_IfClause, OpenMP_InReductionClause,
-    OpenMP_IsDevicePtrClause, OpenMP_MapClauseSkip<assemblyFormat = true>,
-    OpenMP_NowaitClause, OpenMP_PrivateClause, OpenMP_ThreadLimitClause
+    OpenMP_HasDeviceAddrClause, OpenMP_HostEvalClause, OpenMP_IfClause,
----------------
anchuraj wrote:

Nit: A small comment here or a different representation (like `__OpenMP_HostEvalClause`) here to specify its an internal clause would help the readers. 
Do we expect any other construct than `target` to use this clause at the moment

https://github.com/llvm/llvm-project/pull/116049


More information about the llvm-branch-commits mailing list