[llvm-branch-commits] [llvm] [CGData] Refactor Global Merge Functions (PR #115750)

[Kyungwoo Lee via llvm-branch-commits]

kyulee-com wrote:

> Hit an assertion in `ignoreOp` when testing the refactored code.
> 
> ```
> Assertion failed: (OpIdx < I->getNumOperands() && "Invalid operand index"), function ignoreOp, file GlobalMergeFunctions.cpp, line 129.
> Stop reason: hit program assert
> expr I->dump()
>   %6 = tail call ptr @objc_retain(ptr %5), !dbg !576
> 
> p I->getNumOperands()
> 
> (unsigned int) 2
> p OpIdx
> 
> (unsigned int) 4
> ```

Thank you for testing and identifying this bug!
Since we also use this function to verify any function that matches a hash, it should not assert.

https://github.com/llvm/llvm-project/pull/115750