[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

[Ilya Biryukov via llvm-branch-commits]

ilya-biryukov wrote:

> > > Sorry, could you provide the hash id for the commit that avoid the warning?
> > 
> > 
> > I tried running this on head and unfortunately it reproduces on head as well :( So this looks like a sleeper issue which now also gets triggered by this PR in a non-reduced version in our codebase. Looks like it is not rare with module-related issues where most issues remain silent due to lazy deserialization in large codebases. Would it be possible for you to take a look at this issue or provide pointers ?
> 
> Got it. I am not sure if I had the time. But given this is not related to this PR, and it sounds like a regression issue triggered by other commits. Maybe it might be helpful to find that commit to understand the issue better.

+1, I think that fixing the underlying issue to unblock this might be the easiest path. Reducing and checking at every step that compiler from HEAD succeeds and compiler with this commit fails will likely take more time than actually fixing it.
@usx95 would you mind looking at the underlying issue? I'm also happy to help dig through it.

https://github.com/llvm/llvm-project/pull/83237