[llvm-branch-commits] [flang] [Flang][OpenMP] Derived type explicit allocatable member mapping (PR #113557)

Sergio Afonso via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon Nov 4 04:29:52 PST 2024


================
@@ -119,10 +119,10 @@ void gatherFuncAndVarSyms(
 
 mlir::omp::MapInfoOp
 createMapInfoOp(fir::FirOpBuilder &builder, mlir::Location loc,
-                mlir::Value baseAddr, mlir::Value varPtrPtr, std::string name,
-                llvm::ArrayRef<mlir::Value> bounds,
-                llvm::ArrayRef<mlir::Value> members,
-                mlir::DenseIntElementsAttr membersIndex, uint64_t mapType,
+                mlir::Value baseAddr, mlir::Value varPtrPtr,
+                llvm::StringRef name, mlir::ArrayRef<mlir::Value> bounds,
----------------
skatrak wrote:

Nit: A quick search shows that, in the MLIR project, `llvm::ArrayRef` is much more widely used than `mlir::ArrayRef`, but feel free to keep it like this if you think it's better like that.
```suggestion
                llvm::StringRef name, llvm::ArrayRef<mlir::Value> bounds,
```

https://github.com/llvm/llvm-project/pull/113557


More information about the llvm-branch-commits mailing list